Skip to content

feat: Remove early return for NoOpStreamedSpan in set_transaction_name() - #7164

Merged
alexander-alderman-webb merged 12 commits into
masterfrom
webb/remove-set-transaction-name-early-return
Aug 12, 2026
Merged

feat: Remove early return for NoOpStreamedSpan in set_transaction_name()#7164
alexander-alderman-webb merged 12 commits into
masterfrom
webb/remove-set-transaction-name-early-return

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The follow-up PR fails with this otherwise

_ test_catch_exceptions[True-/some_url-ZeroDivisionError-division by zero-tests.integrations.litestar.test_litestar.litestar_app_factory.<locals>.homepage_handler] _
tests/integrations/litestar/test_litestar.py:139: in test_catch_exceptions
    assert expected_tx_name in event["transaction"]
E   AssertionError: assert 'tests.integrations.litestar.test_litestar.litestar_app_factory.<locals>.homepage_handler' in 'http://testserver.local/some_url'

because the ASGI integration sees that the segment source is not set when the span is not sampled.

Issues

Reminders

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 104531 passed | ⏭️ 6677 skipped | Total: 111208 | Pass Rate: 94% | Execution Time: 360m 5s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2483 uncovered lines.
✅ Project coverage is 90.14%. Comparing base (base) to head (head).

Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.13%    90.14%    +0.01%
==========================================
  Files          193       193         —
  Lines        25189     25187        -2
  Branches      9180      9178        -2
==========================================
+ Hits         22704     22704         —
- Misses        2485      2483        -2
- Partials      1432      1430        -2

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review August 11, 2026 11:12
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner August 11, 2026 11:12
Base automatically changed from webb/set-transaction-on-scope to master August 12, 2026 08:31
@alexander-alderman-webb alexander-alderman-webb changed the title feat: Remove early return for NoOpStreamedSpan in set_transaction_name feat: Remove early return for NoOpStreamedSpan in set_transaction_name() Aug 12, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit ea928bd into master Aug 12, 2026
144 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/remove-set-transaction-name-early-return branch August 12, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericapisani ericapisani ericapisani approved these changes
@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-alderman-webb @ericapisani @sentrivana